This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make the sync_cycle_from_offline_to_syncing_to_offline test non flaky #4644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test starts by waiting for nodes 0 and 1 to be major-syncing.
However what I think sometimes happens is that the background task fully syncs these nodes and that therefore
is_major_syncingreturns false. The test then freezes because it's still waiting for the major syncing to happen even though it's already finished.Since this test is entirely single-threaded, it's still unclear to Arkadiy and me why this happens only from time to time. EDIT: probably because libp2p 0.14 spawns connection tasks on a thread pool no matter what