Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename basic-authority to basic-authorship #4640

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Rename basic-authority to basic-authorship #4640

merged 4 commits into from
Jan 16, 2020

Conversation

tomusdrw
Copy link
Contributor

I believe by mistake we confused authorship with authority :)

May require a small fix in Polkadot as well.

@tomusdrw tomusdrw added A0-please_review Pull request needs code review. M4-core labels Jan 16, 2020
@tomusdrw tomusdrw requested a review from gnunicorn January 16, 2020 09:06
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always was confused because of this rename :D

Copy link
Contributor

@gnunicorn gnunicorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one request

@@ -43,6 +43,7 @@ TO_RENAME=(
"sp-finality-granpda sp-finality-grandpa"
"sp-sesssion sp-session"
"sp-tracing-pool sp-transaction-pool"
"sc-basic-authority sc-basic-authorship"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably want to update line 92, too (otherwise updating an older work will be left an in a non-working state). Can't comment there :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks for catching that.

@gavofyork gavofyork merged commit 47c36e6 into master Jan 16, 2020
@gavofyork gavofyork deleted the td-authority branch January 16, 2020 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants