This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Make Proposer instantiation potentially async. #4630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Jan 15, 2020
|
(tiny Polkadot PR incoming - will be followed up by the actual refactor) |
241162b to
4ae8e92
Compare
andresilva
approved these changes
Jan 15, 2020
tomaka
reviewed
Jan 15, 2020
bin/node/cli/src/service.rs
Outdated
| RecordProof::Yes, | ||
| )); | ||
|
|
||
| let new_block = futures::executor::block_on(proposing) |
There was a problem hiding this comment.
May I suggest something like this instead?
Suggested change
| let new_block = futures::executor::block_on(proposing) | |
| let new_block = futures::executor::block_on(async move { | |
| let proposer = proposer_factory.init(&parent_header).await; | |
| proposer.propose( | |
| inherent_data, | |
| digest, | |
| std::time::Duration::from_secs(1), | |
| RecordProof::Yes, | |
| ).await | |
| }); |
There was a problem hiding this comment.
still need to get the async/await into my bloodstream :)
rphmeier
added a commit
that referenced
this pull request
Jan 15, 2020
* Make Proposer instantiation potentially async. * fix node-service test * fix basic-authority doc-test * only block once on futures in test * use async/await
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for an upcoming Polkadot refactor and is strictly more general. This API was always intended to be used in an async context, so it doesn't break any underlying assumptions.