Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add pallet-society and pallet-recovery to substrate node #4622

Merged
merged 3 commits into from
Jan 14, 2020
Merged

Add pallet-society and pallet-recovery to substrate node #4622

merged 3 commits into from
Jan 14, 2020

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Jan 14, 2020

No description provided.

@bkchr bkchr added the A0-please_review Pull request needs code review. label Jan 14, 2020
@bkchr bkchr requested a review from jacogr January 14, 2020 17:05
shawntabrizi
shawntabrizi suggested changes Jan 14, 2020
View reviewed changes
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add Recovery to OnReapAccount in Balances trait

@shawntabrizi
Copy link
Member

We should also remove nicks and add Identity?

@bkchr bkchr requested a review from shawntabrizi January 14, 2020 17:19
@jacogr jacogr mentioned this pull request Jan 14, 2020
Merged
jacogr
jacogr approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks an absolute million for this - you saved me a large amount of time and a pending breakage on Kusama.

@shawntabrizi shawntabrizi merged commit 8cb71bd into master Jan 14, 2020
@shawntabrizi shawntabrizi deleted the bkchr-society-recovery branch January 14, 2020 19:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi approved these changes

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkchr @shawntabrizi @jacogr