Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add trivial EnsureFounder verifier to society #4615

Merged
merged 7 commits into from
Jan 14, 2020
Merged

Conversation

gavofyork
Copy link
Member

Needed for sensible usage of the pallet.

@gavofyork gavofyork added the A0-please_review Pull request needs code review. label Jan 13, 2020
frame/society/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@shawntabrizi shawntabrizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also consider adding:

ensure!(Self::founder() != Some(m.clone()), Error::<T, I>::Founder);

To the remove_member function, which would make it so that this founder cannot be suspended/removed from society.

Also this adds 1 storage read to the found extrinsic.

EDIT: Also, so I understand, this origin will likely be used for the SuspensionJudgementOrigin, but the FounderOrigin in the trait config will need to be some hard-coded address right?

Would it make sense to update the name then to BootstrapOrigin?

@shawntabrizi shawntabrizi added A8-looksgood and removed A0-please_review Pull request needs code review. labels Jan 14, 2020
@gavofyork gavofyork merged commit 012c5ef into master Jan 14, 2020
@gavofyork gavofyork deleted the gav-founder-check branch January 14, 2020 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants