This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix MultiSignature verification for ECDSA keys #4499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @akru signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
I think this one is critical issue because Polkadot and Kusama affected. @bkchr |
|
Hey, ty :) I checked the source code and found more places that required fixes and I also added some tests: #4502 Nevertheless, ty again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ECDSA signing aren't working in runtimes with
MultiSignaturesignatures. #4498Solution
Use uncompressed recovery in
verifyroutine.