Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

less dupes, cleanup #4491

Merged
merged 2 commits into from
Dec 28, 2019
Merged

less dupes, cleanup #4491

merged 2 commits into from
Dec 28, 2019

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Dec 24, 2019

  • less dupes:
    &name is called "the yaml anchor", and used to reduce dupes, like that:
jobname:          &name
  stage:          test
  variables:
    var1:         1
  script:
    - do that

another-jobname:
  # it is the same as "jobname`, but the script is different
  <<:   *name
  script:
    - do this

.gitlab-ci.yml Outdated
<<: *build-binary
script:
- ./.maintain/node-template-release.sh ./artifacts/substrate/substrate-node-template.tar.gz
- cp -r .maintain/docker/substrate.Dockerfile ./artifacts/substrate/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we do this here? And not in the build substrate job above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, right now it's not effective to split these jobs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, we are compiling it right there: https://gitlab.parity.io/parity/substrate/-/jobs/339822#L706 , during cargo build.
Can we use that artifact?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was speaking about the docker file. Putting the node template into its own job sounds reasonable.

@TriplEight TriplEight changed the title build node job is separated from build substrate; less dupes, cleanup less dupes, cleanup Dec 25, 2019
Copy link
Contributor

@gabreal gabreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bkchr bkchr merged commit d1012cd into master Dec 28, 2019
@bkchr bkchr deleted the split_build_job branch December 28, 2019 16:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants