-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
.gitlab-ci.yml
Outdated
<<: *build-binary | ||
script: | ||
- ./.maintain/node-template-release.sh ./artifacts/substrate/substrate-node-template.tar.gz | ||
- cp -r .maintain/docker/substrate.Dockerfile ./artifacts/substrate/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we do this here? And not in the build substrate job above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're right, right now it's not effective to split these jobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, we are compiling it right there: https://gitlab.parity.io/parity/substrate/-/jobs/339822#L706 , during cargo build
.
Can we use that artifact?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was speaking about the docker file. Putting the node template into its own job sounds reasonable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
&name
is called "the yaml anchor", and used to reduce dupes, like that: