Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Obviate manual dependency on wasm-gc executable #3854

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Obviate manual dependency on wasm-gc executable #3854

merged 1 commit into from
Oct 19, 2019

Conversation

bddap
Copy link
Contributor

@bddap bddap commented Oct 18, 2019

This PR Improves user experience by replacing the dependency on the wasm-gc executable with its programatic interface, wasm-gc-api.

@parity-cla-bot
Copy link

It looks like @bddap hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@bddap
Copy link
Contributor Author

bddap commented Oct 18, 2019

[clabot:check]

@parity-cla-bot
Copy link

It looks like @bddap signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@kianenigma kianenigma added the A0-please_review Pull request needs code review. label Oct 19, 2019
kianenigma
kianenigma reviewed Oct 19, 2019
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does seem nice indeed 👍 , @bkchr will probably have a detailed look.

@kianenigma
Copy link
Contributor

except, fyi, the fact that #1262 is trying to remove wasm-gc altogether.

tomusdrw
tomusdrw approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@bkchr bkchr merged commit e479a51 into paritytech:master Oct 19, 2019
Demi-Marie
Demi-Marie approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@Demi-Marie Demi-Marie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bddap bddap deleted the bddap-wasm-gc-as-crate branch November 11, 2019 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kianenigma kianenigma kianenigma left review comments

@Demi-Marie Demi-Marie Demi-Marie approved these changes

@bkchr bkchr bkchr approved these changes

@tomusdrw tomusdrw tomusdrw approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bddap @parity-cla-bot @kianenigma @tomusdrw @bkchr @Demi-Marie