This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Upgrade dependencies whenever “easy” #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
“easy” means that there are no major changes required.
|
Does this supersedes: #3532 ? |
|
It is not even building and when it includes the other pr, it supersedes it. |
|
Please fix the build. |
as updated versions have been published to crates.io
Otherwise, rustc complains (correctly) about duplicate lang items.
Rust does not allow duplicate lang items. When compiled without the `std` feature, `sr-io` defines two lang items. Therefore, `sr-io` compiled without `feature = "std"` must not be linked with `std`. However, `pwasm-utils` and `wasmi-validation` both bring in `std` unless compiled with `default-features = "false"`. This caused a duplicate lang item error. Building both with `default-features = "false"` prevents this error. When building with `feature = "std"`, they should both be built with the `std` feature, so this feature needs to be explicitly depended on.
Three tests used 1 less gas than they had previously.
|
This is ready to be merged. |
pepyakin
reviewed
Sep 26, 2019
pepyakin
reviewed
Sep 26, 2019
pepyakin
reviewed
Sep 26, 2019
pepyakin
reviewed
Sep 26, 2019
| @@ -458,7 +458,7 @@ impl TraitPair for Pair { | |||
| Err(_) => return false | |||
| }; | |||
|
|
|||
| match public_key.verify(message.as_ref(), &sig) { | |||
| match public_key.verify::<sha2::Sha512>(message.as_ref(), &sig) { | |||
There was a problem hiding this comment.
Can you elaborate on those? Are these changes equivalent?
There was a problem hiding this comment.
@tomaka, can you please confirm this?
There was a problem hiding this comment.
I tried to check it myself and it seems that it should be fine. However, I am not 100%.
pepyakin
reviewed
Sep 26, 2019
pepyakin
reviewed
Sep 26, 2019
pepyakin
reviewed
Sep 26, 2019
Co-Authored-By: Sergei Pepyakin <sergei@parity.io>
dev-dependencies need `default-features = false`, too.
…to demi/upgrade-compatible-deps
…ible-deps Also bump more dependencies by minor versions
pepyakin
reviewed
Oct 2, 2019
bkchr
approved these changes
Oct 2, 2019
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Bastian Köcher <bkchr@users.noreply.github.com>
Co-Authored-By: Sergei Pepyakin <sergei@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
“easy” means that there are no major changes required.
Fixes #3685