Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Make Environment, Proposer, OnSlot and SyncOracle mut #3175

Closed
wants to merge 20 commits into from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Jul 23, 2019

Based on top of #3146

Makes the Environment, Proposer, OnSlot and SyncOracle traits accept &mut self instead of &self.
Additionally removes a few unnecessary Arcs.

@tomaka tomaka added the A0-please_review Pull request needs code review. label Jul 23, 2019
Copy link
Contributor

@Demi-Marie Demi-Marie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit (whitespace)

core/consensus/babe/src/tests.rs Outdated Show resolved Hide resolved
@Demi-Marie Demi-Marie added A6-mustntgrumble and removed A0-please_review Pull request needs code review. labels Jul 26, 2019
@tomaka
Copy link
Contributor Author

tomaka commented Jul 28, 2019

I guess this got merged as part of #3206 🤷‍♂️

It would have been cool to merge this first, though.

@tomaka tomaka closed this Jul 28, 2019
@tomaka tomaka deleted the more-mut branch July 28, 2019 07:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants