This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sits on top of #3146 ; will be easier to review after #3146 is in
Related to #2416
When importing a bunch of blocks, we now yield the importing future after every single block.
In other words: the OS thread runs the task, which imports a single block, then the task is added to the work queue again. This makes it possible for the executor/scheduler to interleave that with other tasks in between.
I consequently removed the
keep_going
parameter fromimport_many_blocks
. The caller can now interrupt the operation by just dropping the future. This removes the question of what to return ifkeep_going
returnsfalse
.This makes it possible to add a small delay between each imported block, which at the moment is 0.
For #2416, that delay would be non-zero is browsers, so that we don't eat up all of the CPU and give some space to other tasks.