Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

fix new warning in nightly #14334

Merged
merged 4 commits into from
Jun 13, 2023
Merged

fix new warning in nightly #14334

merged 4 commits into from
Jun 13, 2023

Conversation

gilescope
Copy link
Contributor

There's one place where we are intentionally doing this so have put an exclude in for that.

Same as paritytech/cumulus#2721

@gilescope gilescope added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 9, 2023
@gilescope gilescope requested review from a team June 9, 2023 11:20
@gilescope
Copy link
Contributor Author

Hmm, #[allow(hidden_glob_reexports)] is not yet understood by the CI's version of rust.
For now let's remove all but this one warning.

ggwpez
ggwpez approved these changes Jun 9, 2023
View reviewed changes
frame/staking/src/lib.rs Outdated Show resolved Hide resolved
bkchr
bkchr reviewed Jun 11, 2023
View reviewed changes
frame/staking/src/lib.rs Outdated Show resolved Hide resolved
@bkchr bkchr merged commit 5861423 into master Jun 13, 2023
@bkchr bkchr deleted the giles-remove-warnings branch June 13, 2023 07:36
@gilescope gilescope mentioned this pull request Jun 16, 2023
Merged
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
@gilescope @nathanwhit
fix new warning in nightly (paritytech#14334)
c4ff648 
* fix new warning

* Too soon

* Explicitly import
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gui1117 gui1117 gui1117 approved these changes

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gilescope @bkchr @ggwpez @gui1117