This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix benchmarks failing on scheduler overflow #13143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduler has the upper limit for the number of the calls scheduled per block.
The benchmarks of the
pallet_referenda
andpallet_conviction_voting
do not respect the limit and overflows it if the schedulerMaxScheduledPerBlock
not high enough.For
pallet_referenda
benchmarks the limit reached iftrack.max_deciding > scheduler.max_scheduled_per_block OR
referenda.max_queued > scheduler.max_scheduled_per_block OR
track.max_deciding + referenda.max_queued > scheduler.max_scheduled_per_block
For
pallet_conviction_voting
benchmarks the limit reached ifnumber_of_registered_votes > scheduler.max_scheduled_per_block
This PR fixes it with aim to make it seamless for users.