Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Fix benchmarks failing on scheduler overflow #13143

Closed
wants to merge 6 commits into from

Conversation

muharem
Copy link
Contributor

@muharem muharem commented Jan 14, 2023

Scheduler has the upper limit for the number of the calls scheduled per block.
The benchmarks of the pallet_referenda and pallet_conviction_voting do not respect the limit and overflows it if the scheduler MaxScheduledPerBlock not high enough.

For pallet_referenda benchmarks the limit reached if
track.max_deciding > scheduler.max_scheduled_per_block OR
referenda.max_queued > scheduler.max_scheduled_per_block OR
track.max_deciding + referenda.max_queued > scheduler.max_scheduled_per_block

For pallet_conviction_voting benchmarks the limit reached if
number_of_registered_votes > scheduler.max_scheduled_per_block

This PR fixes it with aim to make it seamless for users.

@muharem muharem added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jan 14, 2023
@muharem muharem changed the title Referenda: fix benchmark's scheduler overflow Fix benchmarks failing on scheduler overflow Jan 24, 2023
@muharem muharem requested review from bkchr and ggwpez January 24, 2023 15:25
@muharem
Copy link
Contributor Author

muharem commented Jan 24, 2023

I did not expect the solution to be so complex, here the alternative way that only helps a user to find a workaround #13231
cc: @bkchr @ggwpez

@stale
Copy link

stale bot commented Feb 24, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A3-stale label Feb 24, 2023
@stale stale bot closed this Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. A3-stale B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant