This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Custom origin for staking pallet calls #12943
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kianenigma
reviewed
Dec 17, 2022
kianenigma
approved these changes
Dec 17, 2022
gpestana
approved these changes
Dec 19, 2022
lexnv
approved these changes
Dec 19, 2022
melekes
approved these changes
Dec 22, 2022
|
Kian raised an issue and I agree that lowering privilege for the critical staking operations like reducing validator count or setting minimum/maximum bounds needs more careful thought. I will make the changes to the PR to only allow slash cancelling and setting minimum commission via |
kianenigma
suggested changes
Dec 25, 2022
|
Updated PR: #13018 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12930
polkadot companion: paritytech/polkadot#6444
I have left
set_invulnerablesto still require root origin since it seems not something that should ever need to be set unless during the initial phase of a chain. Please correct me if this assumption is incorrect.