Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

added add_member_to_rank with sudo origin #12084

Closed
wants to merge 7 commits into from
Closed

added add_member_to_rank with sudo origin #12084

wants to merge 7 commits into from

Conversation

MrishoLukamba
Copy link
Contributor

@MrishoLukamba MrishoLukamba commented Aug 22, 2022 •
edited
Loading

Fixes paritytech/polkadot-sdk#262
Polkadot address: 133WyzJ4cEEbQ4twhT3nQpoXYeTCzeKn8kWfRfEi4XDF7wKh

@MrishoLukamba
Copy link
Contributor Author

Solving issue paritytech/polkadot-sdk#262

@ggwpez
Copy link
Member

ggwpez commented Aug 22, 2022

So there are two Merge Requests now for the exposing of add_member_to_rank?
You could just have fixed the other one, but anyway. Please close the out-dated one so we dont get confused.

@MrishoLukamba
Copy link
Contributor Author

Done closing the other ones

shawntabrizi
shawntabrizi reviewed Aug 25, 2022
View reviewed changes
frame/ranked-collective/src/tests.rs Outdated
#[test]
pub fn add_member_to_rank_work(){
new_test_ext().execute_with(||{
assert_ok!(Club::add_member_to_rank(Origin::root(), 2,1));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be checking the state is updated correctly for the member you are adding to rank

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 6, 2022
@shawntabrizi
Copy link
Member

bot rebase

@paritytech-processbot
Copy link

Rebased

@MrishoLukamba
Copy link
Contributor Author

bot rebase

@Ank4n @kianenigma

@ggwpez
Copy link
Member

ggwpez commented Sep 30, 2022

bot rebase

@paritytech-processbot
Copy link

Rebased

@MrishoLukamba MrishoLukamba mentioned this pull request Oct 18, 2022
Closed
@stale
Copy link

stale bot commented Oct 31, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Oct 31, 2022
@MrishoLukamba
Copy link
Contributor Author

The PR is complete waiting for review only @ggwpez @bkchr

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Oct 31, 2022
@stale
Copy link

stale bot commented Nov 30, 2022

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Nov 30, 2022
@ggwpez
Copy link
Member

ggwpez commented Nov 30, 2022

Code looks good. Please make the CI green.
The main changes for rebasing: Origin renamed to RuntimeOrigin and Weight should be u64 now in the weight file.

@ggwpez
Copy link
Member

ggwpez commented Nov 30, 2022

bot rebase

@paritytech-processbot
Copy link

Rebased

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2103322

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-check-benches
Logs: https://gitlab.parity.io/parity/mirrors/substrate/-/jobs/2103321

@bkchr
Copy link
Member

bkchr commented Dec 7, 2022

@MrishoLukamba if you want this to be merged, please make CI happy. Otherwise please close.

@stale stale bot removed the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Dec 7, 2022
@stale
Copy link

stale bot commented Jan 6, 2023

Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. label Jan 6, 2023
@bkchr bkchr closed this Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shawntabrizi shawntabrizi shawntabrizi left review comments

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. A5-stale Pull request did not receive any updates in a long time. No review needed at this stage. Close it. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fellowship: Expose add_member_to_rank
6 participants
@MrishoLukamba @ggwpez @shawntabrizi @paritytech-cicd-pr @bkchr @kianenigma