Exposed add_member_to_rank #12050
Exposed add_member_to_rank #12050
Conversation
|
User @MrishoLukamba, please sign the CLA here. |
|
This PR is on issue paritytech/polkadot-sdk#262 |
frame/ranked-collective/src/lib.rs
Outdated
| member: T::AccountId, | ||
| rank: Rank | ||
| ) -> DispatchResult { | ||
| let _= ensure_root(origin)?; |
There was a problem hiding this comment.
| let _= ensure_root(origin)?; | |
| ensure_root(origin)?; |
frame/ranked-collective/src/lib.rs
Outdated
| Self::do_add_member_to_rank(member,rank)?; | ||
| Ok(()) |
There was a problem hiding this comment.
| Self::do_add_member_to_rank(member,rank)?; | |
| Ok(()) | |
| Self::do_add_member_to_rank(member, rank) |
frame/ranked-collective/src/lib.rs
Outdated
| @@ -471,6 +471,18 @@ pub mod pallet { | |||
| Self::do_add_member(who) | |||
| } | |||
|
|
|||
| // Only root account can add a member to | |||
| #[pallet::weight(100)] | |||
There was a problem hiding this comment.
need proper weights and benchmark
frame/ranked-collective/src/tests.rs
Outdated
| impl pallet_sudo::Config for Test { | ||
| type Event = Event; | ||
| type Call = Call; | ||
| } | ||
|
|
There was a problem hiding this comment.
you dont need this, so please remove all the stuff related to sudo
|
You should always add the new extrinsic at the bottom of the extrinsics to keep the existing order of the previous extrinsics. |
|
okey am on it, thanks |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
@MrishoLukamba please keep this PR minimal and only adding the new extrinsic. you can open a new PR for the other fellowship feature |
|
This is outdated |
Exposed the extrinsic call only root origin can call.
Performed testing..
Before continuing I need clarifications If i got the instructions right @shawntabrizi
Remaining the first task also to include it as kitchen sink