You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not ever default impl feature gated trait functions, unless you want very weird stuff to happen.
Reason being is that someone will forget to enable the feature and you use the default impl without noticing.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
D3-trivial 🧸
PR contains trivial changes in a runtime directory that do not require an audit
labels
Aug 16, 2022
Actually i dont get what this fixes. if the feature flag is not there, the whole function wont be there? what does it matter if there is a default impl?
Actually i dont get what this fixes. if the feature flag is not there, the whole function wont be there? what does it matter if there is a default impl?
It happens since the feature of the crate which contains the trait is enabled, but the one which should implement is not.
So then it uses the default impl.
It's a consequence of the features being messed up.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_reviewPull request needs code review.B0-silentChanges should not be mentioned in any release notesC1-lowPR touches the given topic and has a low impact on builders.D3-trivial 🧸PR contains trivial changes in a runtime directory that do not require an audit
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not ever default impl feature gated trait functions, unless you want very weird stuff to happen.
Reason being is that someone will forget to enable the feature and you use the default impl without noticing.
#11976 should fix this permanently.