This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix Gov V2 Benchmarks #12022
Merged
Fix Gov V2 Benchmarks #12022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix all of them since they are related? |
|
@ggwpez okay might need to check the other pallets |
|
@ggwpez the other failing pallets are fixed by updating the Polkadot configuration, which I have done. This should be all of them I think. |
shawntabrizi
commented
Aug 13, 2022
Comment on lines
+702
to
+703
| let when = when.saturating_add(alarm_interval).saturating_sub(One::one()) / | ||
| (alarm_interval.saturating_mul(alarm_interval)).max(One::one()); |
There was a problem hiding this comment.
unsafe math here caused a panic in benchmarks
gavofyork
approved these changes
Aug 13, 2022
ggwpez
approved these changes
Aug 13, 2022
KiChjang
approved these changes
Aug 13, 2022
|
bot merge |
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* better benchmark log * Update lib.rs * fix gov2 benchmarks * saturating math + fmt * add comment
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks for Governance V2 were failing: paritytech/polkadot#5205
This should fix them.
Fixes: #11906