This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Crate proc-macro-warning adds GPL 3.0 license dependency
#13872
Labels
J2-unconfirmed
Issue might be valid, but it’s not yet known.
Comments
|
CC @ggwpez |
ggwpez
added a commit
to ggwpez/proc-macro-warning
that referenced
this issue
Apr 11, 2023
Turns out we need this for Substrate, see paritytech/substrate#13872 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added a commit
that referenced
this issue
Apr 11, 2023
Closes #13872 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
We should probably add that automated dependency license check to our CI as well, WDYT @bkchr? |
|
I think we once had one, not sure what happened to it. |
bkchr
pushed a commit
that referenced
this issue
Apr 13, 2023
* Update proc-macro-warning Closes #13872 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update to v0.3.1 (including syn 2.0) Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Revert "Update to v0.3.1 (including syn 2.0)" CI is red since it Polkadot uses a different syn version… Going to update it lean. This reverts commit 3240d37. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this issue
Jul 19, 2023
* Update proc-macro-warning Closes paritytech#13872 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update to v0.3.1 (including syn 2.0) Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Revert "Update to v0.3.1 (including syn 2.0)" CI is red since it Polkadot uses a different syn version… Going to update it lean. This reverts commit 3240d37. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
taqtiqa-mark
pushed a commit
to subversive-upstream/polkadot-sdk-substrate-frame-support
that referenced
this issue
Sep 14, 2023
* Update proc-macro-warning Closes paritytech/substrate#13872 Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Update to v0.3.1 (including syn 2.0) Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> * Revert "Update to v0.3.1 (including syn 2.0)" CI is red since it Polkadot uses a different syn version… Going to update it lean. This reverts commit 3240d379b72f6f722eaf502ed49e9a1b0f79db4b. Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Is there an existing issue?
Experiencing problems? Have you tried our Stack Exchange first?
Description of bug
The newly added proc-macro-warning crate adds a GPL 3.0 dependency to substrate (added in this PR)
To the best of my knowledge (not a lawyer) this violates the GPL v3.0 license.
Steps to reproduce
Noticed after a cargo update via license check in our CI. Check out https://github.com/scs/substrate-api-client/actions/runs/4664840889/jobs/8259110692
The text was updated successfully, but these errors were encountered: