Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Remove unneeded Deserialize code once JSONRPC crate is fixed #1098

Closed
gavofyork opened this issue Nov 11, 2018 · 2 comments
Closed

Remove unneeded Deserialize code once JSONRPC crate is fixed #1098

gavofyork opened this issue Nov 11, 2018 · 2 comments
Assignees
@tomusdrw
Labels
I7-refactor Code needs refactoring.
Milestone
Polkadot

Comments

@gavofyork
Copy link
Member

JSONRPC crate currently is broken in that it requires Serialize and Deserialize regardless of whether a type features only as an argument or a return.
@tomusdrw tomusdrw mentioned this issue Nov 12, 2018
Merged
@gavofyork gavofyork added this to the 1.0 (final) milestone Nov 13, 2018
@gavofyork gavofyork added the I7-refactor Code needs refactoring. label Nov 13, 2018
@gavofyork
Copy link
Member Author

@tomusdrw is there any progress on this in JSONRPC crate?

@gavofyork gavofyork modified the milestones: 1.0 (final), 1.x series Dec 18, 2018
@tomusdrw
Copy link
Contributor

@gavofyork yup, it's backward compatible. Example how to set up Deserialize only bound here: https://github.com/paritytech/jsonrpc/pull/336/files#diff-d41fba166fb0f3c701b3199592549237R13
Requires implementation in substrate now.

@tomusdrw tomusdrw self-assigned this Jan 8, 2019
@tomusdrw tomusdrw mentioned this issue Jan 8, 2019
Merged
lamafab pushed a commit to lamafab/substrate that referenced this issue Jun 16, 2020
@gnunicorn
Companion for paritytech#6025 (paritytech#1098)
67af396
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tomusdrw tomusdrw

Labels
I7-refactor Code needs refactoring.
Projects
None yet
Milestone
Polkadot
Development

No branches or pull requests
2 participants
@gavofyork @tomusdrw