Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

WIP: updated deps #13

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
updated deps
  • Loading branch information
gilescope committed Oct 12, 2021
commit 43ba8840c9f052fbf38cb86ff83a1749b6ec6a2b
10 changes: 5 additions & 5 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ documentation = "https://docs.rs/substrate-bip39"
repository = "https://github.com/paritytech/substrate-bip39"

[dependencies]
pbkdf2 = { version = "0.8.0", default-features = false }
sha2 = "0.9.5"
pbkdf2 = { version = "0.9.0", default-features = false }
sha2 = "0.9.8"
hmac = "0.11.0"
schnorrkel = "0.9.1"
zeroize = { version = "1.0.0", default-features = false }
schnorrkel = "0.10.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use that in Substrate. So, we first should check this and make sure nothing breaks.

Copy link
Author

@gilescope gilescope Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its used with salt.zeroize(); in fn seed_from_entropyto try and zero the password after. (that is used in a couple of places in substrate)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand your answer.

Copy link
Author

@gilescope gilescope Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I commit the above suggestion, then the crate won't compile because zeroize is referenced:

salt.zeroize();

Maybe I misunderstood your initial comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that we don't use schnorrkel 0.10.1 in Substrate while that is already released since quite some time. Before we merge this, we should ensure that we can bump schnorrkel in Substrate as well and nothing breaks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok finally got a combo of this, substrate and schnorrkle that can play nicely together (I think). Let's see how the substrate pr looks...
related PRs: w3f/schnorrkel#76 , paritytech/substrate#10025

zeroize = { version = "1.4.2", default-features = false }

[dev-dependencies]
tiny-bip39 = "0.8.0"
tiny-bip39 = "0.8.2"
rustc-hex = "2.1.0"