Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: optimize buildah build x2 #452

Merged
merged 3 commits into from
Mar 9, 2021
Merged

CI: optimize buildah build x2 #452

merged 3 commits into from
Mar 9, 2021

Conversation

TriplEight
Copy link
Contributor

@TriplEight TriplEight commented Mar 1, 2021 •
edited
Loading

Fix the issue when one wants two tags has to build the image twice.

@TriplEight TriplEight requested review from s3krit, emostov and rcny March 1, 2021 19:34
@TriplEight
Copy link
Contributor Author

(debug build was built successfully, I didn't expect it to publish)
Can be merged.

emostov
emostov approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@emostov emostov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@emostov
Copy link
Contributor

emostov commented Mar 9, 2021

Any chance we can get a second review from @s3krit or @rcny ?

@rcny
Copy link
Contributor

rcny commented Mar 9, 2021

LGTM

@emostov emostov merged commit 3dada4f into master Mar 9, 2021
@emostov emostov deleted the 3x8_optimize_buildah branch March 9, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcny rcny rcny approved these changes

@emostov emostov emostov approved these changes

@s3krit s3krit Awaiting requested review from s3krit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TriplEight @emostov @rcny