fix: Account for polkadot-js changes; Harden createCalcFee
#376
Conversation
src/services/blocks/BlocksService.ts
Outdated
| @@ -390,11 +394,17 @@ export class BlocksService extends AbstractService { | |||
| version.specVersion.toNumber(), | |||
| ]; | |||
|
|
|||
| // The compiler doesn't know this is an AbastractInt so we do a runtime check. | |||
There was a problem hiding this comment.
dq: why doesn't it know that and why can't we add type annotations on line 343?
There was a problem hiding this comment.
@dvdplm Honestly I was on the fence about it. It does not have the TS bindings defined within the API (see here: https://github.com/polkadot-js/api/blob/master/packages/api/src/augment/consts.ts). Not exactly sure why that is but just guessing the script that generates those bindings was run against a runtime that does not use the extrinsicBaseWeight const. I think I will actually just cast it though. No matter the type it certainly will always be a descendant of AbstractInt since it has to be some type of integer.
Co-authored-by: David <dvdplm@gmail.com>
calc/src/calc_fee.rs
Outdated
| @@ -98,6 +98,10 @@ impl CalcFee { | |||
| spec_version: u32, | |||
| ) -> Option<CalcFee> { | |||
| debug::setup(); | |||
| info!( | |||
There was a problem hiding this comment.
Spacing needs to get fixed here.
This PR bumps deps, accounts for changes from polkadot-js/api, and hardens
createCalcFeewhich was affected by the polkadot-js changes.Changes introduced by PR:
createCalcFeeAbstractInts withtoString(10), making sure they are decimal formtoBigInton relevantAbstractIntCalltype before processing argssectionandmethodinstead of the no longer availablesectionNameandmethodNamecalc.js, resulting a big diff there