-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Dock's multiplier & add Dock controller config #365
Conversation
Signed-off-by: lovesh <lovesh.bond@gmail.com>
I changed the |
Thank you for the PR! I believe the issue is because you manually changed the lock file. With the current repo setup the calc package needs to manually linked locally and tested. After this is merged we can publish calc and do another PR to update Sidecar's version of calc in master. I will pull this down within the next day to try it out locally and make sure everything works! Is it ok if I push to your branch? |
I pushed to your branch and linked the calc package locally so it can be tested. However I couldn't find an index of Dock blocks for either network so I could not find any blocks to view that have transactions just to do a sanity check. Do you know of blocks in both networks that have transactions we can do a sanity check with for the calc package updates? Once we can do sanity checks we can then revert the local calc package setup and merge. Other notes:
|
Thanks @emostov.
https://fe.dock.io/#/explorer/query/0xfb2003a3be82b2e03f14f1450c4545ace6f26be44dbbcb6debdcd6ca3b25636e and https://fe.dock.io/?rpc=wss%3A%2F%2Fdanforth-1.dock.io#/explorer/query/0x0c3b9a4f1f420a66c464571ceacff9bd6f6f51baee0ef9046a5b46f19d11c51f.
The types had changed. I've raised a PR.
I will check this. Thanks for the reference. |
Signed-off-by: lovesh <lovesh.bond@gmail.com>
Updated controllers here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just gonna ask for another set of eyes to review and we should be good to merge.
Notes to other reviewers:
- I bumped deps, which resulted in needing to remove
typesRpc
import from @polkadot/apps-config. It appears the structure of exports there has changed and custom RPC defs come through the other exports now. - In order to fully try out this branch locally one will need to replace
"@substrate/calc": "^0.1.2",
with"@substrate/calc": "file:./calc/pkg"
, in thepackage.json
dependencies
section. - ran
build.sh
in calc and removed the .gitignore for the README.md so thepkg
will have the standard NPM structure - After this PR is merged an updated version of calc will be published (by me) and Sidecar will need a PR that updates the lockfile (Publish updated calc package #366)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! |
Signed-off-by: lovesh lovesh.bond@gmail.com