feat!: Bump polkadot-js and document runtime/metadata API regression #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Oct 30, 2020
insipx
approved these changes
Oct 30, 2020
ghost
pushed a commit
to LedgerHQ/substrate-api-sidecar
that referenced
this pull request
Nov 17, 2020
…aritytech#338) * chore(release): 1.0.0 * Save progress * feat: Bump polkadot-js and document runtime/metadata API regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: as documented in the diff here: https://github.com/paritytech/substrate-api-sidecar/compare/zeke-bump-multi?expand=1#diff-78b11c394fc7a8f9c96da1c99dff8d40d78af87d7b40102165467fa34b95977e the response for
runtime/metadatahas at least a known regression for polkadot runtime v16, and likely most older runtimes. I think it relates to polkadot-js/api#2800, although not certain. The change affects the types that show up in the metadata.Other changes:
Decoratedno longer exists and is replaced with the equivalentexpandMetadatafor test utilitiesIntin tests to reflect function signature changeMetadatacreation for test utilities