fix: Catch errors decoding opaque calls (#347)

* fix: Catch errors decoding opaque calls * Add docs to explain the undecoded opaquecalls are not valid * Builld docs * Update docs/src/openapi-v1.yaml Co-authored-by: David <dvdplm@gmail.com> * Update src/controllers/blocks/BlocksController.ts Co-authored-by: David <dvdplm@gmail.com> Co-authored-by: David <dvdplm@gmail.com>
paritytech · Nov 24, 2020 · d128e54 · d128e54
1 parent 260e554
commit d128e54
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 5 deletions.
diff --git a/docs/dist/app.bundle.js b/docs/dist/app.bundle.js
diff --git a/docs/src/openapi-v1.yaml b/docs/src/openapi-v1.yaml
@@ -936,7 +936,10 @@ components:
           format: unsignedInteger
         args:
           type: object
-          description: Object of arguments keyed by parameter name.
+          description: >-
+            Object of arguments keyed by parameter name. Note: if you are expecting an [`OpaqueCall`](https://substrate.dev/rustdocs/v2.0.0/pallet_multisig/type.OpaqueCall.html)
+            and it is not decoded in the response (i.e. it is just a hex string), then Sidecar was
+            not able to decode it and likely that it is not a valid call for the runtime.
         tip:
           type: string
           description: Any tip added to the transaction.

diff --git a/src/controllers/blocks/BlocksController.ts b/src/controllers/blocks/BlocksController.ts
@@ -38,7 +38,9 @@ import AbstractController from '../AbstractController';
  *   - `method`: Extrinsic method.
  *   - `signature`: Object with `signature` and `signer`, or `null` if unsigned.
  *   - `nonce`: Account nonce, if applicable.
- *   - `args`: Array of arguments.
+ *   - `args`: Array of arguments. Note: if you are expecting an [`OpaqueCall`](https://substrate.dev/rustdocs/v2.0.0/pallet_multisig/type.OpaqueCall.html)
+ * 			and it is not decoded in the response (i.e. it is just a hex string), then Sidecar was not
+ * 			able to decode it and likely that it is not a valid call for the runtime.
  *   - `tip`: Any tip added to the transaction.
  *   - `hash`: The transaction's hash.
  *   - `info`: `RuntimeDispatchInfo` for the transaction. Includes the `partialFee`.

diff --git a/src/services/blocks/BlocksService.ts b/src/services/blocks/BlocksService.ts
@@ -448,8 +448,18 @@ export class BlocksService extends AbstractService {
 				) {
 					// multiSig.asMulti.args.call is an OpaqueCall (Vec<u8>) that we
 					// serialize to a polkadot-js Call and parse so it is not a hex blob.
-					const call = registry.createType('Call', argument.toHex());
-					newArgs[paramName] = this.parseGenericCall(call, registry);
+					try {
+						const call = registry.createType(
+							'Call',
+							argument.toHex()
+						);
+						newArgs[paramName] = this.parseGenericCall(
+							call,
+							registry
+						);
+					} catch {
+						newArgs[paramName] = argument;
+					}
 				} else {
 					newArgs[paramName] = argument;
 				}