Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incoming block requests decoding error #2833

Closed
tomaka opened this issue Oct 6, 2022 · 3 comments · Fixed by #2836
Closed

Incoming block requests decoding error #2833

tomaka opened this issue Oct 6, 2022 · 3 comments · Fixed by #2836

Comments

@tomaka
Copy link
Contributor

tomaka commented Oct 6, 2022

2022-10-06T10:24:41.153932360+00:00 WARN full_node::run::network_service: protocol-error peer_id=12D3KooWNHvcCzMEFpG3ZxqGbBaU8e164gdSJRmDbDCn6opwBh1Q error=Error while decoding a received blocks request: ProtobufDecode
@tomaka tomaka mentioned this issue Oct 6, 2022
Merged
@tomaka
Copy link
Contributor Author

tomaka commented Oct 6, 2022

Repro case: [8, 128, 128, 128, 136, 1, 26, 4, 237, 91, 33, 0, 48, 1, 56, 1]

@tomaka
Copy link
Contributor Author

tomaka commented Oct 6, 2022

It's missing the direction field somehow.

@tomaka
Copy link
Contributor Author

tomaka commented Oct 6, 2022

cc paritytech/substrate#12438 w3f/polkadot-spec#548

tomaka added a commit to tomaka/substrate-lite-1 that referenced this issue Oct 6, 2022
@tomaka
Fix paritytech#2833
d381ab3
@tomaka tomaka mentioned this issue Oct 6, 2022
Merged
mergify bot added a commit that referenced this issue Oct 7, 2022
@tomaka @mergify
Interpret 0 maximum block as no maximum (#2835)
f75bc7e 
Substrate can in principle send requests with `0` maximum blocks. This
is meant to mean "no limit".

I've discovered this mismatch while investigating
#2833, however this is not
the same issue as #2833.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@mergify mergify bot closed this as completed in #2836 Oct 7, 2022
mergify bot added a commit that referenced this issue Oct 7, 2022
@tomaka @mergify
Fix #2833 (#2836)
a4d6e27 
Fix #2833

Doesn't warrant a CHANGELOG entry because light clients aren't supposed
to ever receive block requests.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2833 tomaka/substrate-lite-1
1 participant
@tomaka