-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Construct PortableRegistry
dynamically at runtime
#164
Merged
Merged
Changes from 27 commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
8345a3c
WIP: allow constructing MetaTypes at runtime
ascjones 3a14663
Remove fmt config options
ascjones 1e03bd3
Add some docs
ascjones a68f28c
std feature String
ascjones da92e9d
fully qualified String
ascjones 592736a
Fix features build
ascjones 4500520
Generic string parameter for MetaType
ascjones a08ef8a
Remove license_template_path
ascjones 3cacf78
Fmt
ascjones 6476671
Fix fmt
ascjones 6a1343b
Replace MetaFormString trait with cfg based string
ascjones 42db0e3
Remove unused into
ascjones 0c525c6
Fix more errors
ascjones 7dfe55b
Now string types are the same across Meta/Portable, no longer necessa…
ascjones 54ff5fc
Remove custom MetaType and TypeId
ascjones 16e4e79
EXPERIMENT: make all type def fields public to allow construting Port…
ascjones c46186d
Rename test
ascjones 5b47b1b
Fix up type ids in test
ascjones 40b6047
Fix ui test
ascjones 8255c99
*TEMPORARILY* pub registry for PortableType
ascjones 79c19a9
add constructor for portableregistry
xermicus d8c3b5e
constructor for PortableType
xermicus 0e4737f
implement remaining constructors for generic Form
xermicus 8319875
make Type::new constructor public
xermicus ef4c3ee
make remaining constructor public
xermicus 9e48542
add a new custom constructor for path
xermicus b900f54
Merge branch 'master' into aj/custom-meta-types
xermicus 0b45a89
use new_custom in a test
xermicus 6694dc0
Remove not required builder fn for MetaType
ascjones 83a80ef
WIP propogate Form through builders
ascjones ae22be7
Fix up path builders
ascjones ababa57
More fixes
ascjones 383399c
Fix up generated From impls
ascjones 221c2f9
Fix up field builders
ascjones 6caa3d6
Fix up field builder methods for MetaForm
ascjones a36540a
Rename constructor
ascjones b027ae8
Hide pub fields and add portable builder helper methods
ascjones 1de0508
Fmt
ascjones f04d4ef
Explicity export PortableType
ascjones 23c6cb9
Clippy
ascjones 590bc58
Move PortableRegistry to own file, introduce PortableRegistryBuilder
ascjones b5b5a6f
Remove some stray `Str` type params
ascjones 3c9d8dd
Implement PortableRegistryBuilder to manage ids
ascjones a2668a9
Default impl for PortableRegistryBuilder
ascjones 220a59d
implement getter for registered types in PortableRegistryBuilder
xermicus 07057ce
Rename new path constructor
ascjones 07aaef8
Rename new_custom methods to new_portable
ascjones 192d12c
Revert reordering of MetaForm
ascjones 403c720
Move path construction back to MetaForm for non-breaking changes
ascjones 1044c8d
Update path tests
ascjones c9149c2
TypeParameter::new_portable for non breaking change
ascjones File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this is not a required change, just a clippy suggestion since arrays implement
IntoIter