Code

Refactor of failed reviews objects#112

Code

Merged

Bullrich merged 14 commits intomainparitytech/review-bot:mainfrom failure/classparitytech/review-bot:failure/classCopy head branch name to clipboardJan 25, 2024

+330-223

Commits

Commits on Jan 24, 2024

• created error classes to contain review failures

  Show description for a179dc8
  Bullrich

  committed
  a179dc8

  Copy full SHA for a179dc8

• replaced method logic for error reports

  Show description for 1dab71f
  Bullrich

  committed
  1dab71f

  Copy full SHA for 1dab71f

• simplified fellow evaluation

  Show description for 26f881c
  Bullrich

  committed
  26f881c

  Copy full SHA for 26f881c

• moved reports to be the constructor of failures

  Show description for ba656ff
  Bullrich

  committed
  ba656ff

  Copy full SHA for ba656ff

• moved failure class into separated classes

  Bullrich

  committed
  4c5d351

  Copy full SHA for 4c5d351

• applied to new logic

  Bullrich

  committed
  dc6c7ed

  Copy full SHA for dc6c7ed

• simplified 'and-distinct' rule

  Bullrich

  committed
  f37de73

  Copy full SHA for f37de73

• adapted code that evaluates rules

  Show description for e8386e2
  Bullrich

  committed
  e8386e2

  Copy full SHA for e8386e2

Commits on Jan 25, 2024

• Fixed tests

  Bullrich

  committed
  9dd88a4

  Copy full SHA for 9dd88a4

• renamed ruleName to name

  Bullrich

  committed
  7a843b9

  Copy full SHA for 7a843b9

• renamed some fields

  Show description for 8a8e5f0
  Bullrich

  committed
  8a8e5f0

  Copy full SHA for 8a8e5f0

• WIP - Undo this! Test dockerfile

  Bullrich

  committed
  5ebd3ea

  Copy full SHA for 5ebd3ea

• fixed dash in missing users

  Bullrich

  committed
  b6e2411

  Copy full SHA for b6e2411

• fixed summary not being written on update

  Bullrich

  committed
  7e95fd9

  Copy full SHA for 7e95fd9