This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Separate WeightToFee calculation for Kusama and Polkadot
#854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
approved these changes
Feb 19, 2020
General-Beck
pushed a commit
to General-Beck/polkadot
that referenced
this pull request
Feb 20, 2020
…h#854) * Separate `WeightToFee` calculation for Kusama and Polkadot * Bump spec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #847
The
WeightToFeecalculation for Kusama and Polkadot was the same, however the underlying currency distribution was different between the two networks.This lead to a miscalculation of the
WeightToFeeconverter for the networks.This moves the
WeightToFeeimplementation into the code specific to the runtime, and takes advantage of the definedCENTSconstant to ensure that the intendedWeightToFeeconversion is happening.