This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
*: Enable refactored authority discovery #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure existing key types don't change their order by appending the authority discovery id instead of injecting it between im online id and parachain validator id.
|
It looks like @mxinden signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
|
Since we are only gating the feature, i.e. the |
To make sure we are on the same page @jacogr: The additional session key is introduced both if the feature flag is enabled, as well if it is disabled. The feature flag enables the logic of putting ones addresses on the DHT and querying the DHT for other peoples addresses. |
|
100%, it would have been an issue if the key dropped in-and-out of the structure. |
gavofyork
added a commit
that referenced
this pull request
Nov 28, 2019
* Update to latest Substrate master (#615) * Update to latest Substrate master * Remove unneeded patch + warning * Update `Cargo.lock` * Fix tests * Update again * Bump Substrate (#616) * Update lock * Fix * Few fixes * Bump to latest Substrate * Fixes * fix pre-tx-pool compilation * more compilation fixes * Updates for the injection period - Liberal slash-refunding - Instant unbonding * *: Enable refactored authority discovery (#624) * *: Enable authority discovery module * *: List authority discovery id after parachain validator id Make sure existing key types don't change their order by appending the authority discovery id instead of injecting it between im online id and parachain validator id. * *: Gate authority discovery module behind feature flag * cli/src/lib.rs: Fix warnings * cli/src/lib.rs: Shorten line length * Bump Substrate * Bump Substrate * Line widths * Line widths again * Revert bump.
tomusdrw
added a commit
that referenced
this pull request
Mar 26, 2021
* Document relayers fund existence and add root account. * Introduce initialize method instead of assuming that relayer_fund_account is always required. * cargo fmt --all * Fix benchmarks. * cargo fmt --all * Fix docs for the relayer fund account.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the refactored version of the authority discovery module into the
masterbranch for the Kusamamv0.7release. The feature is gated behind the--enable-authority-discoveryfeature flag.Important: This pull request replaces #601. It points at https://github.com/paritytech/polkadot/tree/fix_polkadot_for_light_tx_pool3 for now which in turn is based on #623. Once those branches are in
masterI can point this pull request againstmasteras well.