Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

add dispute metrics, some chores #3842

Merged
25 commits merged into from
Sep 16, 2021
Merged

add dispute metrics, some chores #3842

25 commits merged into from
Sep 16, 2021

Conversation

drahnr
Copy link
Contributor

@drahnr drahnr commented Sep 14, 2021 •
edited
Loading

Extracting generic parts from #3639 that do not depend on the CI

  • renames malus::Filter* to malus::Intercept*
  • adds additional arguments to a trait
  • makes the SubsystemSender for TestContext* generic
  • adds subsystem metrics to dispute coordinator

@drahnr drahnr added A3-in_progress Pull request is in progress. No review needed at this stage. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Sep 14, 2021
@drahnr drahnr self-assigned this Sep 14, 2021
@drahnr drahnr changed the title dispute metrics add dispute metrics, some chores Sep 14, 2021
@drahnr drahnr force-pushed the bernhard-dispute-metrics branch from d2e67bc to 3f35229 Compare September 14, 2021 10:12
@drahnr drahnr force-pushed the bernhard-dispute-metrics branch from 3f35229 to 44ce041 Compare September 14, 2021 10:13
@drahnr drahnr added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Sep 14, 2021
@drahnr drahnr added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. labels Sep 14, 2021
@drahnr drahnr added A0-please_review Pull request needs code review. A3-in_progress Pull request is in progress. No review needed at this stage. and removed A3-in_progress Pull request is in progress. No review needed at this stage. A0-please_review Pull request needs code review. labels Sep 14, 2021
ordian
ordian reviewed Sep 14, 2021
View reviewed changes
node/core/dispute-coordinator/src/metrics.rs Outdated Show resolved Hide resolved
node/core/dispute-coordinator/src/metrics.rs Outdated Show resolved Hide resolved
node/core/dispute-coordinator/src/metrics.rs Outdated Show resolved Hide resolved
node/malus/Cargo.toml Outdated Show resolved Hide resolved
node/malus/src/tests.rs Show resolved Hide resolved
drahnr and others added 8 commits September 14, 2021 21:05
@drahnr @ordian
Update node/malus/Cargo.toml
a0e80f4 
Co-authored-by: Andronik Ordian <write@reusable.software>
@drahnr @ordian
Update node/core/dispute-coordinator/src/metrics.rs
b5e6def 
Co-authored-by: Andronik Ordian <write@reusable.software>
@drahnr @ordian
Update node/core/dispute-coordinator/src/metrics.rs
7641a4b 
Co-authored-by: Andronik Ordian <write@reusable.software>
@drahnr @ordian
Update node/core/dispute-coordinator/src/metrics.rs
9f1c632 
Co-authored-by: Andronik Ordian <write@reusable.software>
@drahnr
add license header
201de95
@drahnr
fix lockfile
1211d63
@drahnr
new with opts
5b5bd91
@drahnr
fmt
ad5f5a5
@drahnr drahnr requested a review from ordian September 15, 2021 09:13
ordian
ordian approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to feature gate some metrics stuff on feature = "disputes", see CI failure.

@drahnr
Copy link
Contributor Author

drahnr commented Sep 15, 2021

You need to feature gate some metrics stuff on feature = "disputes", see CI failure.

I had to add it to keep it coherent between real and dummy. So I feature gating can only be done on the impl-part.

@drahnr
Copy link
Contributor Author

drahnr commented Sep 15, 2021

bot merge

@ghost
Copy link

ghost commented Sep 15, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 15, 2021

Merge aborted: Checks failed for a911304

@drahnr
Copy link
Contributor Author

drahnr commented Sep 16, 2021

bot merge

@ghost
Copy link

ghost commented Sep 16, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Sep 16, 2021

Merge aborted: Checks failed for a911304

@drahnr
Copy link
Contributor Author

drahnr commented Sep 16, 2021

bot merge

@ghost
Copy link

ghost commented Sep 16, 2021

Waiting for commit status.

@ghost ghost merged commit a3902fb into master Sep 16, 2021
@ghost ghost deleted the bernhard-dispute-metrics branch September 16, 2021 08:19
ordian added a commit that referenced this pull request Sep 16, 2021
@ordian
Merge branch 'master' into temporary-malus
c81f175 
* master:
  Raised nits on #3813 (#3844)
  Don't try to connect to ourselves. (#3855)
  add dispute metrics, some chores (#3842)
  add type info derive to senderror (#3860)
  Companion for #8615: enrich metadata with type information (#3336)
  approval-voting: processed wakeups can also update approval state (#3848)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
  Bump tracing from 0.1.26 to 0.1.27 (#3841)
  Companion for substrate#9711 (#3801)
  fix complaints in CI (#3838)
ordian added a commit that referenced this pull request Sep 17, 2021
@ordian
Merge branch 'master' into bernhard-malus-fx
93c6d06 
* master:
  Raised nits on #3813 (#3844)
  Don't try to connect to ourselves. (#3855)
  add dispute metrics, some chores (#3842)
  add type info derive to senderror (#3860)
  Companion for #8615: enrich metadata with type information (#3336)
  approval-voting: processed wakeups can also update approval state (#3848)
  Add build with docker info to README (#3843)
  improve approval tracing (#3846)
  UMP: Support Overweight messages (#3575)
  Companion for substrate#9115 (#3265)
  Better error messages. (#3835)
  Put all authorities of a session into `SessionInfo`. (#3813)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ordian ordian ordian approved these changes

@eskimor eskimor eskimor approved these changes

Assignees

@drahnr drahnr

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drahnr @eskimor @ordian