This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix sanity check in relay chain selection #3749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordian
approved these changes
Aug 31, 2021
| @@ -417,7 +417,7 @@ where | |||
|
|
|||
| let lag = if cfg!(feature = "disputes") { | |||
| // Prevent sending flawed data to the dispute-coordinator. | |||
| if Some(subchain_block_descriptions.len() as _) != | |||
| if Some(subchain_block_descriptions.len() as u32 - 1) != | |||
There was a problem hiding this comment.
Do we guarantee that block descriptions are always not-empty?
Would be nice to add a comment why -1.
eskimor
reviewed
Aug 31, 2021
| @@ -417,7 +417,7 @@ where | |||
|
|
|||
| let lag = if cfg!(feature = "disputes") { | |||
| // Prevent sending flawed data to the dispute-coordinator. | |||
| if Some(subchain_block_descriptions.len() as _) != | |||
| if Some(subchain_block_descriptions.len() as u32 - 1) != | |||
| subchain_number.checked_sub(target_number) | |||
There was a problem hiding this comment.
while equivalent, I would suggest to use the same calculation as in approval voting. So instead of doing the -1, I would change the checked_sub(target_number) to checked_sub(target_number + 1).
ordian
reviewed
Aug 31, 2021
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3678
The sanity check was including the current unfinalized block in the sanity check for sending
subchain_block_descriptionsto the dispute coordinator.