This repository was archived by the owner on Nov 15, 2023. It is now read-only.
avoid reshuffling active validators #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. It's handy if validators keep the same index from when they get elected to when they loose an election. :) |
|
That'd be good, but this PR actually does not do that. The validator indices will change pretty much every session based on the random seed. |
|
We'll deal with that later then. It'll be a while I think before we need it for anything. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug introduced in #2586 which caused a re-shuffle of validators in the
SessionInfo, breaking everything that depends onValidatorIndex.