Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Polkadot companion for #8143 #2535

Merged
merged 23 commits into from
Mar 11, 2021
Merged

Polkadot companion for #8143 #2535

merged 23 commits into from
Mar 11, 2021

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Feb 26, 2021

No description provided.

@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Feb 26, 2021
@cecton cecton added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 26, 2021
@cecton cecton mentioned this pull request Feb 26, 2021
Merged
@cecton cecton requested a review from bkchr March 5, 2021 08:15
bkchr
bkchr suggested changes Mar 5, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any preparation for reusing the telemetry worker when being started from Cumulus?

maciejhirsz
maciejhirsz approved these changes Mar 11, 2021
View reviewed changes
Copy link
Contributor

@maciejhirsz maciejhirsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cecton added a commit to paritytech/substrate that referenced this pull request Mar 11, 2021
@cecton
Rework telemetry to replace the use of tracing with an object we pass…
6ac86d5 
… around (#8143)

polkadot companion: paritytech/polkadot#2535
@cecton cecton marked this pull request as ready for review March 11, 2021 10:06
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Mar 11, 2021
@cecton
Copy link
Contributor Author

cecton commented Mar 11, 2021

bot merge

@ghost
Copy link

ghost commented Mar 11, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Mar 11, 2021

Checks failed; merge aborted.

@cecton
Copy link
Contributor Author

cecton commented Mar 11, 2021

bot merge

@ghost
Copy link

ghost commented Mar 11, 2021

Waiting for commit status.

@ghost
Copy link

ghost commented Mar 11, 2021

Merge failed: "Required status check \"continuous-integration/gitlab-check-transaction-versions\" is expected."

@cecton cecton merged commit c8649e5 into master Mar 11, 2021
@cecton cecton deleted the cecton-rework-telemetry branch March 11, 2021 11:11
jordy25519 pushed a commit to cennznet/substrate that referenced this pull request Sep 17, 2021
@cecton @jordy25519
Rework telemetry to replace the use of tracing with an object we pass…
8f625c6 
… around (paritytech#8143)

polkadot companion: paritytech/polkadot#2535
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maciejhirsz maciejhirsz maciejhirsz approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cecton @maciejhirsz @bkchr