Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Restrict collating_using_adder_collator test on feature real-overseer #1947

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

coriolinus
Copy link
Contributor

This test can only pass given that feature, and runs forever otherwise.

This change ensure that a careless cargo test --all doesn't run forever.

This test can only pass given that feature, and runs forever otherwise.

This change ensure that a careless `cargo test --all` doesn't run forever.
@coriolinus coriolinus added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Nov 12, 2020
Copy link
Member

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coriolinus
Copy link
Contributor Author

coriolinus commented Nov 12, 2020

If we used required-features, then no future tests in the same crate would run unless that feature were specified, which I think is not the behavior we'd expect and desire. I like the granularity of disabling only this single test in the event that it can't pass.

[edit]
Oh, I see, looks like we can specify the name of the test as well as required features. That's less a limitation then I'd thought, then. Even so, my instinct is to prefer the more local annotation.

@ordian ordian merged commit 355558a into master Nov 12, 2020
@ordian ordian deleted the prgn-feature-gate-adder-collator-test branch November 12, 2020 15:16
bkchr added a commit that referenced this pull request Nov 12, 2020
bkchr added a commit that referenced this pull request Nov 12, 2020
bkchr added a commit that referenced this pull request Nov 12, 2020
* Revert "Restrict collating_using_adder_collator test on feature real-overseer (#1947)"

This reverts commit 355558a.

* Revert "Revert "Restrict collating_using_adder_collator test on feature real-overseer (#1947)""

This reverts commit 4e92cdf.

* Test something
ordian added a commit that referenced this pull request Nov 16, 2020
* master:
  Make sure adder collator test is executed in CI (#1949)
  Restrict collating_using_adder_collator test on feature real-overseer (#1947)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants