This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Rollback spec_version and fix check_runtime #1868
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Oct 28, 2020
|
bot merge |
|
Waiting for commit status. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spec_versionfor polkadot, kusama and westend were bumped in #1775 erroneously, due to a bug in the check_runtime CI job. It didn't account for release-candidate-style tags (i.e.,v0.8.26-rc1). We only need to bump thespec_versionon a new release, not every time there's a new tag. Since there has not yet been a new release,spec_versiondoes not yet need to be bumped. This PR rolls backspec_versionand fixes the bug to only pick up tags like^v1.2.3$