This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Companion for #6237 (Ensure Origin w/ OR) #1223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
reviewed
Jun 10, 2020
runtime/kusama/src/lib.rs
Outdated
| @@ -109,6 +110,16 @@ impl Filter<Call> for BaseFilter { | |||
| pub struct IsCallable; | |||
| frame_support::impl_filter_stack!(IsCallable, BaseFilter, Call, is_callable); | |||
|
|
|||
| #[cfg(feature = "runtime-benchmarks")] | |||
There was a problem hiding this comment.
why the feature gating? benchmarks should be reflective of the on-chain logic. and in any case, i would want the on-chain logic to be the EnsureOneOf value.
Merged
This reverts commit 963cb7b.
|
Subsumed in #1222 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR that updates the Polkadot and Kusama runtime to keep the ability for Root origin to access some functions through EnsureOrigin check
paritytech/substrate#6237