This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[CI] Expose WASM binaries on publish #1093
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
19dfc0f
add build-wasm-release CI job
s3krit 86bc723
temporarily run build-wasm-release everywhere
s3krit e387a82
Merge branch 'master' into mp-expose-wasm-binaries
s3krit 516e075
temporary job to inspect artifacts dir
s3krit fcce1b4
fix test job
s3krit 7f73850
fix test job again
s3krit 54af85f
remove temporary job
s3krit fbb1e1e
remove FIXME for when to run jobs
s3krit 799fdc6
remove pointless echo
s3krit f3757cf
Change cargo build for wasm-pack
s3krit 1d1882c
Checksum polkadot_cli files
s3krit c336193
make separate wasm dir for artifacts
s3krit 47acecb
fix nits
s3krit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can artifacts be fetched that way from two different jobs which ran in parallel before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, wasn't sure about this myself so I made a test job to verify it: https://gitlab.parity.io/parity/polkadot/-/jobs/507196
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job!