Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[WIP] migrate unmigrated claims #1002

Closed
wants to merge 3 commits into from
Closed

Conversation

jam10o-new
Copy link

@jam10o-new jam10o-new commented Apr 15, 2020

Rel: #932, #910

236 accounts on
the claims pallet currently remain unmigrated because they were omitted from claims.scale

This PR reintroduces migration code to migrate these accounts.

TODO:

  • identify 236 accounts from the polkascan scrapes which need to be migrated (235 have been identified so far, remaining one does not appear to correspond to any known DOT allocation on ethereum.) EDIT: the accounts
  • convert identified accounts into a claims.scale file.

Alternatively to this PR: we can call batch mint_claims for these accounts, and kill their old keys.

@jam10o-new jam10o-new added the A0-please_review Pull request needs code review. label Apr 15, 2020
@parity-cla-bot
Copy link

It looks like @joshua-mir signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@bkchr
Copy link
Member

bkchr commented Apr 15, 2020

Couldn't this be done by an council motion that sets the data in the storage directly?

@jam10o-new
Copy link
Author

jam10o-new commented Apr 15, 2020

I'm personally okay with minting new claims and killing all old keys in a batched extrinsic

@jam10o-new jam10o-new added A3-in_progress Pull request is in progress. No review needed at this stage. and removed A0-please_review Pull request needs code review. B2-breaksapi labels Apr 15, 2020
@emielsebastiaan
Copy link

I am okay with that too as long as we are 100% transparent about what happened. That seems like the easiest way to make those impacted happy (again). That said, I’ll leave it to the experts.

@jam10o-new
Copy link
Author

closing in favor of a council proposal

@jam10o-new jam10o-new closed this Apr 15, 2020
@jam10o-new jam10o-new deleted the jam-claims-temp-patch branch April 15, 2020 16:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A3-in_progress Pull request is in progress. No review needed at this stage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants