Add migrations prelude to frame umbrella crate #7119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolkadotDom
commented
Jan 11, 2025
| @@ -242,11 +244,6 @@ pub mod prelude { | |||
| }; | |||
| } | |||
|
|
|||
| #[cfg(any(feature = "try-runtime", test))] | |||
| pub mod try_runtime { | |||
There was a problem hiding this comment.
Bit unsure if this is better removed or nested under testing and migrations prelude as I'm not familiar with Frame usage patterns in their totality. Thoughts appreciated 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we don't yet have a migrations prelude, which felt prudent; This PR adds that. In addition, it also shuffles the try_runtime prelude into both the testing and migrations prelude, as it seemed it would be unclear where to source the try_runtime types from with the redundancy introduced by the migrations prelude. Also small update to multisig pallet to use new prelude.
@re-gius