-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] malus-collator: implement malicious collator submitting same collation to all backing groups #6924
base: master
Are you sure you want to change the base?
Conversation
…or submitting same collation to all backing groups
…o Collator implementation
…extend test scenario
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall!
polkadot/parachain/test-parachains/undying/collator/src/main.rs
Outdated
Show resolved
Hide resolved
charlie: js-script ./assign-core.js with "2,2000,57600" return is 0 within 600 seconds | ||
|
||
# Ensure parachains made progress. | ||
alice: parachain 2000 block height is at least 10 within 300 seconds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to add some better assertions, including some log checks that indeed validators got invalid candidates.
Also, if you want this test being run in the CI, it needs to be added to the gitlab config in polkadot.yml
polkadot/zombienet_tests/functional/0020-same-collation-to-all-assigned-cores.zndsl
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,54 @@ | |||
[settings] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DSL is deprecated, we have a goal to port tests to Zombienet SDK.
All GitHub workflows were cancelled due to failure one of the required jobs. |
Issues
Description
Modified the undying collator to include a malus mode, in which it submits the same collation to all assigned backing groups.
TODO
same-collation-to-all-assigned-cores.toml
using theassign-core.js
script;same-collation-to-all-assigned-cores.zndsl
Zombienet test;