Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] malus-collator: implement malicious collator submitting same collation to all backing groups #6924

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

sw10pa
Copy link
Member

@sw10pa sw10pa commented Dec 17, 2024

Issues

Description

Modified the undying collator to include a malus mode, in which it submits the same collation to all assigned backing groups.

TODO

…or submitting same collation to all backing groups
@sw10pa sw10pa added the T10-tests This PR/Issue is related to tests. label Dec 17, 2024
@sw10pa sw10pa requested review from alindima and sandreim December 17, 2024 12:17
@sw10pa sw10pa self-assigned this Dec 17, 2024
Copy link
Contributor

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall!

charlie: js-script ./assign-core.js with "2,2000,57600" return is 0 within 600 seconds

# Ensure parachains made progress.
alice: parachain 2000 block height is at least 10 within 300 seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add some better assertions, including some log checks that indeed validators got invalid candidates.
Also, if you want this test being run in the CI, it needs to be added to the gitlab config in polkadot.yml

@@ -0,0 +1,54 @@
[settings]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DSL is deprecated, we have a goal to port tests to Zombienet SDK.

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12946769122
Failed job name: test-linux-stable-no-try-runtime

@sw10pa sw10pa changed the title [WIP] malus-collator: implement initial version of malicious collator submitting same collation to all backing groups [WIP] malus-collator: implement malicious collator submitting same collation to all backing groups Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T10-tests This PR/Issue is related to tests.
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

3 participants