Migrate pallet safe mode to umbrella crate #6905
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-gius
reviewed
Jan 6, 2025
…github.com/Krayt78/polkadot-sdk into migrate-pallet-safe-mode-to-umbrella-crate
re-gius
reviewed
Jan 7, 2025
gui1117
reviewed
Jan 25, 2025
| @@ -22,8 +22,7 @@ | |||
| use super::*; | |||
| use crate::mock::{RuntimeCall, *}; | |||
|
|
|||
| use frame_support::{assert_err, assert_noop, assert_ok, hypothetically_ok, traits::Currency}; | |||
| use sp_runtime::traits::Dispatchable; | |||
| use frame::{deps::frame_support::hypothetically_ok, testing_prelude::*, traits::Currency}; | |||
There was a problem hiding this comment.
hypothetically_ok can be reexported in testing_prelude.
There was a problem hiding this comment.
the reason i didnt export it is because its only used in 2 crates, is it enough to justify putting it in the prelude ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504