Add unstable-api feature flag to pallet-revive
#6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
added 2 commits
December 13, 2024 11:09
athei
requested changes
Dec 13, 2024
athei
reviewed
Dec 13, 2024
|
Got tests and benchmarks passing, feature only in |
athei
reviewed
Dec 13, 2024
athei
approved these changes
Dec 13, 2024
|
Thanks a lot. Let's get this in quickly. Will be a PITA to rebase. |
xermicus
approved these changes
Dec 13, 2024
|
The |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
- Fixed failing docs.rs build for `pallet-revive-uapi` by fixing a wring attribute in the manifest (we were using `default-target` instead of `targets`) - Removed the macros defining host functions because the cfg attributes introduced in #6866 won't work on them - Added an docs.rs specific attribute so that the `unstable-hostfn` feature tag will show up on the functions that are guarded behind it. --------- Co-authored-by: command-bot <>
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
Follow up refactor to paritytech#6844 (review) I still need to finish adding `#[cfg(feature = "unstable-api")]` to the rest of the tests and make sure all tests pass, I want to make sure I'm moving into right direction first @athei @xermicus --------- Co-authored-by: DavidK <davidk@parity.io> Co-authored-by: Alexander Theißen <alex.theissen@me.com>
dudo50
pushed a commit
to paraspell-research/polkadot-sdk
that referenced
this pull request
Jan 4, 2025
- Fixed failing docs.rs build for `pallet-revive-uapi` by fixing a wring attribute in the manifest (we were using `default-target` instead of `targets`) - Removed the macros defining host functions because the cfg attributes introduced in paritytech#6866 won't work on them - Added an docs.rs specific attribute so that the `unstable-hostfn` feature tag will show up on the functions that are guarded behind it. --------- Co-authored-by: command-bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up refactor to #6844 (review)
I still need to finish adding
#[cfg(feature = "unstable-api")]to the rest of the tests and make sure all tests pass, I want to make sure I'm moving into right direction first@athei @xermicus