pallet-example-basic: Missing Hooks
#6701
Conversation
|
User @rainbow-promise, please sign the CLA here. |
|
Hello @ggwpez A few questions:
|
| #[pallet::storage] | ||
| pub(super) type Dummy<T: Config> = StorageValue<_, T::Balance>; |
There was a problem hiding this comment.
Instead of deleting them, please do something interesting with it as an example.
As this is an example pallet: it should showcase some sensible things that can be done with storage items etc. And it should document these things so that a beginner can understand it.
| } | ||
|
|
||
| fn on_poll(_n: BlockNumberFor<T>, _weight: &mut WeightMeter) { | ||
| unimplemented!() |
There was a problem hiding this comment.
Maybe it isn't so good to have unimplemented here and also other places.
If user wants to experiment and modify the function and execute some tests then it will trigger everywhere.
If think it is better to just have an inner comment //
| } | ||
| } | ||
| */ |
There was a problem hiding this comment.
why removed? it is a good example.
| @@ -169,7 +173,7 @@ fn counted_map_works() { | |||
| assert_eq!(CountedMap::<Test>::count(), 1); | |||
| }) | |||
| } | |||
|
|
|||
| */ | |||
There was a problem hiding this comment.
maybe remove it completely or keep it.
Resolves #6398
Proposed Implementation
pre_upgrade: Retrieve and assert the on-chain storage version, returning an emptyVec.on_runtime_upgrade: Clear all storage items and raise the on-chainStorageVersionto 1.post_upgrade: Assert the new on-chain storage version.Notes
The
try-statehook validates invariants in the storage items, as the pallet contains trivial logic this will be leftunimplemented()