Migrate pallet-authority-discovery to umbrella crate
#6619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
92 tasks
|
please review @re-gius |
re-gius
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Fix TOML formatting, see https://github.com/paritytech/polkadot-sdk/actions/runs/12700272273/job/35402669145?pr=6619
re-gius
reviewed
Jan 17, 2025
| @@ -19,37 +19,23 @@ targets = ["x86_64-unknown-linux-gnu"] | |||
| codec = { features = [ | |||
| "derive", | |||
| ], workspace = true } | |||
| frame-support = { workspace = true } | |||
| frame-system = { workspace = true } | |||
| frame = { workspace = true, features = ["experimental", "runtime"] } | |||
There was a problem hiding this comment.
Please remove the experimental feature flag from now on as in #7177
Suggested change
| frame = { workspace = true, features = ["experimental", "runtime"] } | |
| frame = { workspace = true, features = ["runtime"] } |
re-gius
reviewed
Jan 22, 2025
substrate/frame/src/lib.rs
Outdated
| pub use sp_core::{ | ||
| crypto::{VrfPublic, VrfSecret, Wraps}, | ||
| hashing::*, | ||
| Pair, H160, H256, H512, U256, U512, |
There was a problem hiding this comment.
please remove Pair because it appears in several pallets with different meanings
|
please review @re-gius @kianenigma |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6504