-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-revive] implement tx origin API #6105
Merged
Changes from 6 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
09e8c47
[pallet-revive] implement tx origin API
xermicus 5563391
Update from xermicus running command 'prdoc --audience runtime_dev --…
actions-user 32e6095
typo
xermicus a8c01be
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
0dd2c17
Merge branch 'master' into cl/origin
xermicus f472086
".git/.scripts/commands/fmt/fmt.sh"
f59d4e4
add a fixture to test that the syscall exists and works as expected
xermicus 2a186f7
Update substrate/frame/revive/src/wasm/runtime.rs
xermicus 584a59b
Apply suggestions from code review
xermicus 1c27bdf
enhance uapi method comment
xermicus efa3f06
return a ref and update fixture
xermicus 3f06067
Merge branch 'master' into cl/origin
xermicus 06129c7
revert fmt change
xermicus 8c6a070
".git/.scripts/commands/fmt/fmt.sh"
2af28af
Merge branch 'master' into cl/origin
xermicus 6a08871
Merge branch 'master' into cl/origin
xermicus 9640c27
Merge branch 'master' into cl/origin
xermicus c4dc08a
fix comment
xermicus 2608b90
Merge branch 'master' into cl/origin
xermicus 3b1e024
Merge branch 'master' into cl/origin
xermicus f999fd8
weights
xermicus 3b8c0bd
".git/.scripts/commands/bench/bench.sh" --subcommand=pallet --runtime…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
title: '[pallet-revive] implement tx origin API' | ||
doc: | ||
- audience: | ||
- Runtime Dev | ||
description: Implement a syscall to retreive the transaction origin. | ||
crates: | ||
- name: pallet-revive | ||
bump: minor | ||
- name: pallet-revive-uapi | ||
bump: minor |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not return a reference?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy paste from
fn caller
which returns a value too. But I don't see why it can't be a reference. Changed it