Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #5887 #6082

Merged
merged 7 commits into from
Oct 16, 2024
Merged

[stable2409] Backport #5887 #6082

merged 7 commits into from
Oct 16, 2024

Conversation

s0me0ne-unkn0wn
Copy link
Contributor

No description provided.

Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@s0me0ne-unkn0wn s0me0ne-unkn0wn added the A3-backport Pull request is already reviewed well in another branch. label Oct 16, 2024
@EgorPopelyaev EgorPopelyaev merged commit 5937099 into stable2409 Oct 16, 2024
181 of 218 checks passed
@EgorPopelyaev EgorPopelyaev deleted the s0me0ne/backport5887 branch October 16, 2024 12:12
@s0me0ne-unkn0wn s0me0ne-unkn0wn restored the s0me0ne/backport5887 branch November 27, 2024 09:41
@s0me0ne-unkn0wn s0me0ne-unkn0wn deleted the s0me0ne/backport5887 branch November 27, 2024 12:47
s0me0ne-unkn0wn added a commit that referenced this pull request Nov 27, 2024
s0me0ne-unkn0wn added a commit that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants