Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #5649 #5826

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #5649 into stable2409 from bkontur.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5649-to-stable2409
git worktree add --checkout .worktree/backport-5649-to-stable2409 backport-5649-to-stable2409
cd .worktree/backport-5649-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 710e74ddefdff1e36b77ba65abe54feb0ac15040
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 24, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7429091

This PR primarily fixes the issue with
`zombienet-bridges-0001-asset-transfer-works` (see:
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7404903).

The PR looks large, but most of the changes involve splitting `LaneId`
into `LegacyLaneId` and `HashedLaneId`. All pallets now use `LaneId` as
a generic parameter.

The actual bridging pallets are now backward compatible and work with
actual **substrate-relay v1.6.10**, which does not even known anything
about permissionless lanes or the new pallet changes.

- [x] added migration for `pallet_bridge_relayers` and
`RewardsAccountParams` change order of params, which generates different
accounts

- [ ] fix monitoring for
`at_{}_relay_{}_reward_for_msgs_from_{}_on_lane_{}`
- [ ] check sovereign reward accounts - because of changed
`RewardsAccountParams`
- [ ] deploy another messages instances for permissionless lanes - on
BHs or AHs?
- [ ] return back `open_and_close_bridge_works` for another
`pallet-bridge-messages` instance

---------

Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
(cherry picked from commit 710e74d)
@bkontur bkontur force-pushed the backport-5649-to-stable2409 branch from 22bbf6f to cd76a52 Compare September 24, 2024 22:26
@bkontur bkontur marked this pull request as ready for review September 24, 2024 22:28
@bkontur bkontur requested a review from a team as a code owner September 24, 2024 22:28
@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 24, 2024 22:29
@EgorPopelyaev EgorPopelyaev merged commit 5f342c8 into stable2409 Sep 25, 2024
185 of 190 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-5649-to-stable2409 branch September 25, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants