pallet macro: do not generate try-runtime related code when frame-support doesn't have try-runtime. #5099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is not a breaking change. Should I include a prdoc? |
gupnik
approved these changes
Jul 22, 2024
|
The CI pipeline was cancelled due to failure one of the required jobs. |
is it? |
ggwpez
approved these changes
Jul 22, 2024
substrate/frame/support/test/tests/pallet_ui/pass/no_warning.rs
Outdated
Show resolved
Hide resolved
bkchr
reviewed
Jul 22, 2024
| proc_macro2::TokenStream::new() | ||
| }; | ||
|
|
||
| let try_state = if cfg!(feature = "try-runtime") { |
There was a problem hiding this comment.
We should not do this. This is partly "cursed". Sometimes this is not really working well.
You can create a macro in frame_support using this macro and then you can use this to guard the code. Here is an example of what I mean.
There was a problem hiding this comment.
ah yes, I implemented as you suggested here 61fa26d
kianenigma
approved these changes
Jul 23, 2024
bkchr
approved these changes
Jul 23, 2024
Merged
via the queue into
paritytech:master
with commit Jul 24, 2024
8a96d07
155 of 160 checks passed
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…port doesn't have try-runtime. (paritytech#5099) Status: Ready for review Fix paritytech#5092 Introduce a new macro in frame-support which discard content if `try-runtime` is not enabled. Use this macro inside `frame-support-procedural` to generate code only when `frame-support` is compiled with `try-runtime`. --------- Co-authored-by: Bastian Köcher <git@kchr.de>
ordian
added a commit
that referenced
this pull request
Aug 6, 2024
* master: (27 commits) Bridges improved tests and nits (#5128) Fix misleading comment about RewardHandler in epm config (#3095) Introduce a workflow updating the wishlist leaderboards (#5085) membership: Restructure pallet into separate files (#4536) Fix after ring-proof api change (#5126) Bump paritytech/review-bot from 2.4.0 to 2.5.0 (#5057) Bump docker/login-action from 3.0.0 to 3.3.0 (#5109) Bump docker/build-push-action from 5.1.0 to 6.5.0 (#5108) Bump peter-evans/create-pull-request from 5.0.0 to 6.1.0 (#5093) Tx Payment: drop ED requirements for tx payments with exchangeable asset (#4488) Remove `pallet-getter` usage from pallet-transaction-payment (#4970) pallet macro: do not generate try-runtime related code when frame-support doesn't have try-runtime. (#5099) fix(chain-spec): ChainSpecBuilder with object as default genesis (#4345) Migrate BEEFY BLS crypto to bls12-381 curve (#4931) Bump clap from 4.5.9 to 4.5.10 in the known_good_semver group (#5120) Use jobserver in wasm-builder to limit concurrency of spawned cargo processes (#4946) include events for voting (#4613) [subsystem-bench] Add mocks for own assignments triggering (#5042) Remove not-audited warning (#5114) hotfix: blockchain/backend: Skip genesis leaf to unblock syncing (#5103) ...
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Ready for review
Fix #5092
Introduce a new macro in frame-support which discard content if
try-runtimeis not enabled.Use this macro inside
frame-support-proceduralto generate code only whenframe-supportis compiled withtry-runtime.